Fix the parser for the .fi TLD (Closes: #42) #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuyseng
added a commit
to kuyseng/whois-parser
that referenced
this pull request
Apr 20, 2021
weppos#133 The whole response format was changed in 2016, this commit changes the tests, the scanner and the parser in order to respond to the change. Co-authored-by: Petri Salminen <petri@seravo.fi>
|
Thanks for this @elguitar, for the record I ended up starting my fork in which I merged some of the pending PRs (including yours slightly adapted in a5b0f63) and more fixes to come. So people who need this can use my fork in the meantime: gem 'whois-parser', github: 'jarthod/whois-parser' # Unofficial but more up-to-date fork, check status at https://github.com/jarthod/whois-parser |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The whole response format was changed in 2016, this PR changes the tests,
the scanner and the parser in order to respond to the change.