Open
Conversation
….sh file permissions to be executable.
Relative paths don't require us to modify the file when automatically (by a script) integrating ZRTP4PJ to projects.
- transport_rtp_cb2 calls zrtp->stream_rtp_cb2 which is received by transport_attach2 if available (otherwise, transport_rtp_cb is called which calls zrtp->stream_rtp_cb) - Registered new callback within transport_attach2 - We probably don't need to register transport_rtp_cb2 within the old transport_attach function as transport_rtp_cb2 likely didn't exist then
(There's no "stream_rtcp_cb2")
Changed zid file name from "simple.zip" to "/tmp/simple.zip" to avoid conflicts with iOS permissions (sandboxed apps are not allowed to create files within the app folder but probably are allowed to create files within "/tmp")
...to ensure that rtp_cb2 is not used before pjsip v2.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for pjsip 2.8 & 2.9 (latest as of Sep. 28, '19).
The major change is the addition of another rtp callback.
Some commits to pjsip introduced
rtp_cb2as another struct member ofpjmedia_transport_attach_param. This lead tortp_cbbecome deprecated and resulted in crashes becausertp_cbwasNULL. This PR fixes that issue dynamically by checking what version is being used via macros made available by pjsip (the changed was introduced in v2.8).This change is a requirement, a must-have, for this project in order to also work with all versions of pjsip.
Side note:
I'd squash all commits as most of them are about debug output.
I also accidentally removed the patch. Lmk if you'd like me to re-add it.
This PR closes #28