Open
Conversation
Allows scoping search results to a single account when multiple accounts are synced into the same archive. Resolves the account identifier to a source_id via GetSourceByIdentifier and sets q.AccountID directly on the parsed search.Query, which buildSearchQueryParts already handles. No interface changes needed.
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
--accountflag tomsgvault searchto scope results to a single account when multiple accounts are synced into the same archive.Problem
With multiple accounts synced,
searchreturns results from all of them interleaved, with no way to filter at query time:Solution
Implementation
Resolves the account identifier to a
source_idviaGetSourceByIdentifierand setsq.AccountIDdirectly on the parsedsearch.Query.buildSearchQueryPartsalready handlesAccountID, so no changes to internal packages or theEngineinterface are needed. The lookup runs beforeensureFTSIndexso an invalid account fails immediately.Closes #164.
Testing
go test -tags fts5 ./...passes. No new lint issues introduced (golangci-lint run ./...reports only pre-existing issues in other files).Tested manually against a two-account archive: