Skip to content

fix(config): guard banner backgroundColor parsing #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Olexandr88 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(config): guard banner backgroundColor parsing #362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,9 +288,13 @@ async function parseBanner(banner: Banner): Promise<Banner<true> | undefined> {
if (typeof banner === 'string') return undefined
if (typeof banner === 'object') {
if ('textColor' in banner) return banner.textColor
if ('backgroundColor' in banner && banner.backgroundColor) {
const chroma = (await import('chroma-js')).default
return chroma.contrast(banner.backgroundColor, 'white') < 4.5 ? 'black' : 'white'
if ('backgroundColor' in banner && typeof banner.backgroundColor === 'string') {
try {
const chroma = (await import('chroma-js')).default
return chroma.contrast(banner.backgroundColor, 'white') < 4.5 ? 'black' : 'white'
} catch {
return undefined
}
}
}
return undefined
Expand Down