feat: support config as callback with env context#380
Draft
feat: support config as callback with env context#380
Conversation
|
@2wheeh is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
I will rework based on v2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add callback-style config support.
Changes
1. Pass env from
vite.config.tstoresolveVocsConfig()Before: env was not passed, always defaulted to
{ command: 'serve', mode: 'development' }After: Vite's
ConfigEnvis forwarded properly (exceptisSsrBuild- I guess it's not needed forvocs?)2. Separate
defineConfig/resolveConfigdefineConfig: Type helper passthrough:colorSchemegeneric only works for object formresolveConfig: Resolves callback/object and parses config:resolveVocsConfigwhen loading user configdefineConfig,resolveConfigSince
defineConfigis now a passthrough (lazy), parsing happens inresolveVocsConfigviaresolveConfig.Usage
Better support monorepo with tsconfig
customConditionsresolving exports.source in dev mode:(This is actually why I opened this PR)