set accept language request header for selected language #1168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandgeider
reviewed
Dec 5, 2025
src/utils/url.ts
Outdated
| } | ||
|
|
||
| export function getAcceptLanguage():string{ | ||
| const languages = navigator.languages || []; // get language preference from user's browser settings |
Member
There was a problem hiding this comment.
I'm not sure right now, but where do the languages the languages in navigator come from? Are these only the ones set in the browser preferences?
In any case, the user can also manually change the app's language with the parameter in the URL, so we should make sure we send that one as the first entry (this can be read from useTranslation(), i18n.language)
This changes based on what the user selected via the UI, while the browser settings always remain the same.
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Related Issue(s)
Closes Send selected language in request header #1132
Please check that the PR fulfills these requirements