Open
Conversation
added 11 commits
August 27, 2019 20:03
`credentials` configuration option name of GCS plugin is changed to `service_account_key` for clarity.
For GCS lhsm plugin, the service account key file is now optional. Credentials to acces bucket are created by either retrieving the defalt credentials with read/write scope to GCS or by using the service account key file.
mhugues
force-pushed
the
feature/lhsm-plugin-gcs
branch
from
5c0d002 to
bcd0d03
Compare
Contributor
Author
|
Hello, Let me know how we can move this forward. |
edwardsp
referenced
this pull request
in edwardsp/lemur
Mar 24, 2021
* Retrieve SAS from a kv * Refresh token after 24hrs * Disable sharedkey auth * Ze's comments
|
This is a valuable addition to Lemur for GCP users. Is there a possibility of this getting merged upstream? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature to add a plugin for supporting google cloud storage (GCS)