Merged
Conversation
Having a central point to acknowledge its non-existence will hopefully provide some clarity for #5560 and other changes.
domenic
requested changes
Jun 2, 2020
Member
domenic
left a comment
domenic
left a comment
There was a problem hiding this comment.
"To get a browsing session, given an environment settings object environment, return the ..."?
I think the more usual pattern would be to define
An <span>environment settings object</span>'s <dfn data-export="" data-dfn-for="environment settings object">browsing session</dfn> is its ...although we should probably note somehow that the definition only applies for window ESOs?
Member
Author
I was thinking that would require adding this to the set of algorithm fields for environment settings object, which I didn't really want to do. As you say, it only needs to work for windows, at least for now. |
domenic
approved these changes
Jun 3, 2020
| <var>environment</var> is the result of running these steps:</p> | ||
|
|
||
| <ol> | ||
| <li><p>Assert: <var>environment</var> has a <span>responsible document</span>.</p></li> |
Member
There was a problem hiding this comment.
Note that I'd like to remove responsible document (#4335), but I'm fine with adding this usage since it's easy to convert in the future whenever I get around to that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having a central point to acknowledge its non-existence will hopefully provide some clarity for #5560 and other changes.
It would also be useful to go from an environment settings object to a browsing session, but there is already a way to get there. Maybe instead there should be "To get a browsing session, given an environment settings object environment, return the ..."?
/history.html ( diff )
/index.html ( diff )