Support ANY consistency level
#381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@whatyouhide I did not find any test for CLs, and given that |
Owner
Can you add one? Just a simple |
Annopaolo
force-pushed
the
support-any-consistency
branch
from
5ccb493 to
c5bd8ab
Compare
Contributor
Author
|
@whatyouhide here you are, sorry for the delay. I added a new test case because it seemed no files checked for consistency levels, but I can change if needed |
Owner
|
Ah that new test is failing. Is it passing locally? It might be failing on a diff protocol version. |
`ANY` is the lowest possible CL for writes. Allow queries to run with `:any` consistency instead of crashing. Signed-off-by: Arnaldo Cesco <arnaldo.cesco@secomind.com>
Annopaolo
force-pushed
the
support-any-consistency
branch
from
c5bd8ab to
f268f67
Compare
Contributor
Author
|
Done, I was missing a parameter 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ANYis the lowest possible CL for writes. Allow queries to run with:anyconsistency instead of crashing.Closes #380