Fix viable phone number and use it in parse logic #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the check for a valid phone number and use
is_viablewhen parsing.The regex from the java implementation for checking if a phone number is viable is
Previously, we were checking if we had 3 consecutive digits before alpha characters. However, between these numbers there could be punctuations as well. Which this PR fixes.
Furthermore, I added the
is_viablefunction to the parse logic such that we only continue parsing viable phone numbers, which fixes #80.