Support Google tag manager #100
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
To be honest, I'm not a fan of this approach.
I know there is currently a Google Analytics configuration in this package's config file, but I don't think it should stay there. The goal is to avoid polluting this config file with potential options for every possible use case. Instead, I think it would be better to provide the needed configurations as arguments to the ->google() & ->gtm() methods when they are used.
Also, since both are "google" shortcuts, I'd recommend using better method names:
googleAnalytics()googleTagManager()
Finally, did you test this with a real Google Tag Manager setup?
…configuration file
Debatty-Tom
force-pushed
the
feature-handle-GTM
branch
from
22a1fb3 to
15e1eee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover #23.
Added gtm method which display the good script tag if user consent.
If a GTM id is set in the .env at the GOOGLE_TAG_MANAGER_ID key or in the config/cookieconsent.php file, the default script for gtm is set to denied the google tag manager access.
In the config, you will also find the gtm_consent key, which is an array of the different categories of cookies defined by Google Tag Manager that you can modify.
Google Analytics and Google Tag Manager use the same cookies which means it's not necessary to use both. If you only need Google Anlaytics, use the google method. If you need the Google Tag Manager you can use the gtm method.