Remove all cookies if reset action #104
Open
+17
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| foreach ($keys as $key) { | ||
| $response->withoutCookie( | ||
| cookie: $key, | ||
| domain: config('cookieconsent.cookie.domain'), |
There was a problem hiding this comment.
How does this cope with cookies not related to the defined cookieconsent.cookie.domain?
There was a problem hiding this comment.
This only manages cookies for the domain specified here. For subdomains, the only option would be to use JavaScript to loop through all possibilities, as we cannot obtain the domain with document.cookie, but is this the correct way to proceed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve #5 by deleting all the cookies except the laravel-session and XSRF-token.
I tried to do it in JS, but after several attempts, I ended up doing it in the backend. Since it comes from the request, we don't need to make any wild guesses, contrary to what you feared.