Added csp option on default script tag #98
+34
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toonvandenbos
requested changes
Oct 15, 2025
config/cookieconsent.php
Outdated
Comment on lines
58
to
67
| /* | ||
| |-------------------------------------------------------------------------- | ||
| | CSP configuration | ||
| |-------------------------------------------------------------------------- | ||
| | | ||
| | Most cookie notices display a link to a dedicated page explaining | ||
| | the extended cookies usage policy. If your application has such a page | ||
| | you can add its route name here. | ||
| | | ||
| */ |
There was a problem hiding this comment.
Please add a specific description for the CSP configuration, including:
- What it relates to (you may add a link to Spatie's CSP package)
- How to configure it for Spatie's CSP package:
env('CSP_ENABLE', false) && env('CSP_NONCE_ENABLED', true)
config/cookieconsent.php
Outdated
| | | ||
| */ | ||
|
|
||
| 'csp_enable' => env('CSP_ENABLE', false), |
There was a problem hiding this comment.
Just set it to false by default. People using spatie's package should refer to the updated configuration description (see previous comment).
src/CookiesManager.php
Outdated
|
|
||
| use Illuminate\Http\Request; | ||
| use Illuminate\Support\Facades\Cookie as CookieFacade; | ||
| use Illuminate\Support\Str; |
src/CookiesManager.php
Outdated
Comment on lines
202
to
216
| $csp_enable = config('cookieconsent.csp_enable', false); | ||
|
|
||
| return '<script ' | ||
| . 'src="' . route('cookieconsent.script') . '?id=' | ||
| . md5(\filemtime(LCC_ROOT . '/dist/script.js')) . '" ' | ||
| . ($csp_enable ? 'nonce="' . $this->generateCspNonce() . '" ' : '') | ||
| . 'defer' | ||
| . '></script>'; | ||
| } | ||
|
|
||
| protected function generateCspNonce(): string | ||
| { | ||
| return bin2hex(random_bytes(16)); | ||
| } | ||
|
|
There was a problem hiding this comment.
Developers should be able to plug into this nonce generating behavior since their CSP setup could be completely different. For instance, when using spatie's package, one should be able to use the package's nonce_generator. In fact, I can't think of a single use case where the nonce generated by this package would be used.
… tag and added explanations in the readme
|
Waiting for the #96 to be merged to add the csp nonce to the modal script. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover #46 by adding csp option on default script tag.
By setting CSP_ENABLE=true in your .env file, this package provides access to a nonce in the default script tag. The CSP_ENABLE flag is also used by Spatie’s laravel-csp package.
A CSP nonce should consist of at least 16 bytes of cryptographically secure random data, and be safe for use in HTML attributes and HTTP headers. I chose to use bin2hex() instead of base64_encode() because it can generate characters that are unsafe for these contexts.
Since a csp_nonce() helper does not exist by default, I implemented a custom one.