Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ec5db9ab3d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| context['first_page_href'] = '.' | ||
| context['page_suffix'] = '#past-contests' | ||
| context['search_query'] = self.search_query | ||
| context.update(paginate_query_context(self.request)) |
There was a problem hiding this comment.
Build contest pagination URLs from base route
Calling paginate_query_context(self.request) here derives page_prefix from request.path, so when a user is on the still-registered path form /contests/<int:page> (via paged_list_view in dmoj/urls.py), links are generated like /contests/2?page=3. InfinitePaginationMixin.paginate_queryset prioritizes self.kwargs['page'] over request.GET['page'], so those links keep rendering page 2 and pagination controls stop working for path-based bookmarks/direct links.
Useful? React with 👍 / 👎.
Automated fix for TASK-20260204.