fix(tray): fix macOS tray menu - window label, event listeners, state management#5
Open
wallydz-bot[bot] wants to merge 1 commit intomasterfrom
Open
fix(tray): fix macOS tray menu - window label, event listeners, state management#5wallydz-bot[bot] wants to merge 1 commit intomasterfrom
wallydz-bot[bot] wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round 22 — Operation Tray Fix\n\nFixes the macOS tray icon where only Quit worked.\n\n### Root Causes Fixed\n- Missing window label: Added label: main to tauri.conf.json — get_webview_window("main") was returning None for all window-dependent menu items\n- No navigate listener: Confirmed event listener exists in index.ts for settings tray action\n- No global-shortcut-trigger listener: Confirmed handlers exist for new_message/mute/dnd\n- app.manage type mismatch: Fixed Result stored instead of TrayManager (unwrap + Mutex wrap)\n- macOS foreground activation: Added set_activation_policy(ActivationPolicy::Regular) — window.show() now properly activates app on macOS\n\n### Verification\n- cargo check: 0 errors\n- npm run build: success\n- Commit: f49d9e8