Skip to content

Added option to load language files in a synchronous way #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rollbackpt wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added option to load language files in a synchronous way #110

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6d0941
Added option to load language files in a synchronous way
rollbackpt Aug 3, 2016
2d6ea2c
Merge branch 'master' into master
rollbackpt Aug 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions src/jquery.i18n.messagestore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
var MessageStore = function () {
this.messages = {};
this.sources = {};
};
},
sync = false;

/**
* See https://github.com/wikimedia/jquery.i18n/wiki/Specification#wiki-Message_File_Loading
Expand Down Expand Up @@ -111,13 +112,17 @@
function jsonMessageLoader( url ) {
var deferred = $.Deferred();

$.getJSON( url )
.done( deferred.resolve )
.fail( function ( jqxhr, settings, exception ) {
$.i18n.log( 'Error in loading messages from ' + url + ' Exception: ' + exception );
// Ignore 404 exception, because we are handling fallabacks explicitly
deferred.resolve();
} );
$.ajax( {
url: url,
dataType: 'json',
async: !sync
Copy link
Copy Markdown
Member

@santhoshtr santhoshtr Sep 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

synchronous loading of any resource is very bad from performanace and user experience perspective. If used with a complex application, the implications are very random and unexpected.
So, if there is a usecase that is not really supported by this library, we can discuss alternate approaches but this approach is problematic

} )
.done( deferred.resolve )
.fail( function ( jqxhr, settings, exception ) {
$.i18n.log( 'Error in loading messages from ' + url + ' Exception: ' + exception );
// Ignore 404 exception, because we are handling fallabacks explicitly
deferred.resolve();
} );

return deferred.promise();
}
Expand Down