Dynamically import only the needed i18n files#222
Open
iiirxs wants to merge 1 commit intowikimedia:mainfrom
Open
Dynamically import only the needed i18n files#222iiirxs wants to merge 1 commit intowikimedia:mainfrom
iiirxs wants to merge 1 commit intowikimedia:mainfrom
Conversation
Member
|
Thanks @iiirxs for the PR. This aligns with the work in Phabricator ticket T282727. Backward compatibility must be supported, the changes should also work for the Wikipedia Preview WordPress plugin, and this should be documented in the README.md file to explain its usage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the appropriate logic so that the code only imports dynamically the translation messages for the languages that are actually needed, instead of loading the messages for all languages.
Regarding, the built artifacts, the
wikipedia-preview.umd.cjswill continue to load all translation messages, as this is intended to be used as standalone file that contains the whole library. However, the wikipedia-preview.js ESM module will now only load the translation messages for the required families.Steps followed for testing:
vite.config.app.jswith the following contents (mostly copied fromvite.config.jsfile:Build the new files to use them directly inside HTML:
vite build --config ./dynamic-import-test/vite.config.app.jsThen inside
demo/articles/french.html:<script src="../../app/my-app.js"></script>Finally, test that the french.html file only loads the required messages.