Set maven update policy to 'daily' for Glow provisioning updates #192
Conversation
WolfgangHG
requested review from
bstansberry,
darranl,
emmartins,
jamezp and
jmesnil
as code owners
| <releases> | ||
| <enabled>true</enabled> | ||
| <updatePolicy>never</updatePolicy> | ||
| <updatePolicy>daily</updatePolicy> |
There was a problem hiding this comment.
Daily, not sure, why not always? You can still miss some update if you are unlucky.
There was a problem hiding this comment.
@jfdenise
As far as I understand, this situation can only happen if I run a maven build on a project using Glow provisioning - maven checks for updates and finds nothing new. The same day a new feature pack is released and a new WildFly release is done, and the user immediately wants to switch to this new WildFly release. This would fail because the local maven cache still contains an older version.
Is this correct?
I picked "daily" because it is the maven default. I don't know how much performance impact a "always" update policy would have, but it could probably slow down build time a bit, dependending on internet speed.
If my understanding of the possible provisioning problem is true, my opinion is that this is a quite rare condition and not worth the impact on build time etc.. But you are the pros with more detailed insight - if you consider "daily" or "once per hour" better, I will change it.
There was a problem hiding this comment.
If daily is the default, why we would set it? I think that always is ok, you could add a comment saying why we set it so.
There was a problem hiding this comment.
@jfdenise I changed the updatePolicy to always - but only for the regular repository, not for the plugin repos.
There was a problem hiding this comment.
The plugin repo is not in use when resolving the WildFly Glow metadata.
|
Thanks @WolfgangHG, @jmesnil and @jfdenise |
4 participants
This fixes #191: Glow provisioning cannot download updated featurepacks if the project created from the archetype is updated to a newer WildFly version.
Reason: all maven repositories are defined with
updatePolicy = never.The pull request is larger than necessary - I aligned the definition of maven central and JBoss repositories and also disabled all snapshot repositories.