Skip to content

Shell 3.16 support#24

Open
ptpt wants to merge 4 commits intowilfm:masterfrom
ptpt:shell-3.16
Open

Shell 3.16 support#24
ptpt wants to merge 4 commits intowilfm:masterfrom
ptpt:shell-3.16

Conversation

@ptpt
Copy link
Copy Markdown

@ptpt ptpt commented Apr 27, 2015

Gnome 3.16 support #21

Fixed some bugs due to API changes

@yutzhead
Copy link
Copy Markdown

yutzhead commented May 3, 2015

Yeah, hi, it's Bill Lumburgh.
Lumburgh
What's happenin'?

This build still has a problem on Gnome 3.16. On some windows, the header bar hides but the space stays black instead until the window is unmaximized and maximized again.

So, if someone could just go ahead and fix it as soon as possible, that would be terrific.

Mkay?

@ptpt
Copy link
Copy Markdown
Author

ptpt commented May 3, 2015

Hi @yutzhead , I reproduced the issue you mentioned. If you hide title bar with xprop directly, the black area will appear there.

xprop -id XWINDOW_ID -f _GTK_HIDE_TITLEBAR_WHEN_MAXIMIZED 32c -set _GTK_HIDE_TITLEBAR_WHEN_MAXIMIZED 0x1

If you lock your screen and then come back it appears again. This is likely to be a bug in Gnome Shell that doesn't work with the GTK property very well. I will try to report the problem to Gnome Shell.

Merged fixes from pixel-saver extension back (https://github.com/deadalnix/pixel-saver/pull/11/commits)

Thanks to @matthijskooijman for these changes.
@MichaelTunnell
Copy link
Copy Markdown

ptpt yea this is not a problem with this update this a problem with the extension and the shell entirely, it has always happened for me actually.

@desyncr
Copy link
Copy Markdown

desyncr commented May 30, 2015

@yutzhead As mentioned before the black bar on top is not caused by the update or related with 3.16. And it's addressed here. Pull those changes locally and report any problem there.

@ptpt Can report the extension loads and work properly on 3.16. The only issue I saw is:

(gnome-shell:7036): Gjs-WARNING **: JS ERROR: TypeError: Shell.StageInputMode is undefined onFocusChange@/home/user/.local/share/gnome-shell/extensions/maximus-two@wilfinitlike.gmail.com/app_menu.js:79

Which is also addressed with #26 at here.

@desyncr desyncr mentioned this pull request May 30, 2015
@ptpt
Copy link
Copy Markdown
Author

ptpt commented May 31, 2015

@desyncr Thanks for the PR. It works very well.

@ptpt ptpt changed the title Shell 3.16 Shell 3.16 support Jun 1, 2015
@jamerlan
Copy link
Copy Markdown

so.. will someone merge it???

@desyncr
Copy link
Copy Markdown

desyncr commented Jul 28, 2015

Maybe @wilfm doesn't have time or interest to review and merge stuff. Hope a contributor to handle merges and stuff is added eventually.

@jamerlan
Copy link
Copy Markdown

I tested ptpt version with fedora 22 and it works good! Please merge pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants