Replace window checking idle loop with a timeout#33
Replace window checking idle loop with a timeout#33danielkza wants to merge 1 commit intowilfm:masterfrom
Conversation
Also, make sure the onWindowAdded callback is only called once when the window is already properly added to the compositor. Keep the timeout running otherwise, instead of setting a new one up every time.
|
Thanks for the fix. |
|
Oops spoke too soon, upon restart MaximusTwo won't load as an extension. |
ghost
mentioned this pull request
|
@xhn35rq Any errors in the GNOME debug UI? (Alt-F2 -> lg) |
|
@danielkza thank you for checking with me, I just tried it again and this time no errors. I had to edit gnome-shell version in metadata.json to get it working as I'm on 3.14. So far gnome-shell is hovering between 0% and 5% depending on usage, which is usual for me. So far so good! Thanks again! |
|
I'll be able to test this on 3.16 and 3.18 then should be able to merge it. Do you think this should be available for 3.14 as well? |
|
I've had no issues with this branch so far. |
|
I have left this mess for far too long :( I will try and merge and fix stuff this evening or tomorrow... |
|
Tested on ArchLinux 64bit with Gnome 3.18 and everything looks fine, after about a full day of use. |
4 participants
Also, make sure the onWindowAdded callback is only called once when the
window is already properly added to the compositor. Keep the timeout
running otherwise, instead of setting a new one up every time.
This seems to fix #32 for me, but needs more testing, and testing on GNOME versions other than 3.16.