Open
Conversation
Newer versions of h2o build scripts started to check LIBUV_VERSION. It's set when libuv is found by pkg-config, but is not set when FindLibUV.cmake is used. That causes h2o build scripts to ignore headers it's found. Explicitly setting LIBUV_VERSION to any value above 1.0.0, fixes the build.
GCC no longer treats strlen("111.111.111.111") as a constant, and complains
about it being used for array size.
Author
|
Two additional changes were needed, but looks like the Travis build result is now successful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found some issue that prevented me from building the source code.