Make encrypting secrets with symmetric-encryption optional #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was assumed you were using symmetric-encryption to encrypt the secrets in the database for extra security, however the gem itself wasn't actually required, leading to trouble setting things up for the first time. Now encryption is treated as an optional added layer of security with instructions on how to accomplish it. This should also open the door to using alternate encryption strategies. This should fix williamatodd#21.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was assumed you were using symmetric-encryption to encrypt
the secrets in the database for extra security, however the gem itself
wasn't actually required, leading to trouble setting things up for the
first time.
Now encryption is treated as an optional added layer of security with
instructions on how to accomplish it. This should also open the door to
using alternate encryption strategies.
This should fix #21.