forked from quarck/CalendarNotification
-
Notifications
You must be signed in to change notification settings - Fork 1
feat: show next alert time #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williscool
commented
Dec 25, 2025
android/app/src/main/java/com/github/quarck/calnotify/Settings.kt
Outdated
Show resolved
Hide resolved
android/app/src/main/java/com/github/quarck/calnotify/calendar/EventRecord.kt
Show resolved
Hide resolved
android/app/src/main/java/com/github/quarck/calnotify/ui/TestActivity.kt
Outdated
Show resolved
Hide resolved
2 tasks
Code Coverage Report
Files
|
📊 Code Coverage Summary
|
100762a to
4c1a0cf
Compare
android/app/src/main/java/com/github/quarck/calnotify/ui/TestActivity.kt
Outdated
Show resolved
Hide resolved
📊 Code Coverage Summary
|
📊 Code Coverage Summary
|
android/app/src/main/java/com/github/quarck/calnotify/textutils/EventFormatter.kt
Show resolved
Hide resolved
📊 Code Coverage Summary
|
📊 Code Coverage Summary
|
Closes #89
- Add displayNextGCalReminder (default ON) and displayNextAppAlert (default OFF) settings - Show 📅 for calendar reminders, 🔔 for app alerts, 🔇 prefix for muted - Collapsed notifications show soonest next alert in title - GCal wins ties when both are same time - Add TestActivity buttons for individual, collapsed, and muted scenarios - Add Robolectric tests for calculation logic
doing emoji X instead of emoji in X makes it more clear this is static showing the next from the original display of the notfication. not an active countdown
c2e855f to
80d2b85
Compare
📊 Code Coverage Summary
|
📊 Code Coverage Summary
|
android/app/src/main/java/com/github/quarck/calnotify/textutils/EventFormatter.kt
Show resolved
Hide resolved
📊 Code Coverage Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calendar
Muted
App Alert
Muted
refs #89 and #87
fixes #90 fixes #14
Note
Introduces a user-configurable next-alert indicator in notifications and hardens CI to prevent accidental dev-page exposure.
EventFormatter(📅 calendar reminders, 🔔 app alerts, optional 🔇 prefix) withcalculateNextNotificationlogic andformatNextNotificationIndicator[ForCollapsed]EventNotificationManagerdisplayNextGCalReminder(default true) anddisplayNextAppAlert(default false) with UI innotification_preferences_x.xmland backing inSettingsEventRecord.getNextAlertTimeAfterhelper for computing future remindersTestActivityandactivity_test.xmlwith buttons to demo individual/collapsed/muted/app-alert casesreminder_attext; addsnext_*_indicatorandmuted_prefixsafety_checksjob and release step runningscripts/check_dev_page_hidden.sh; build gated on itbuild.gradlereadsDEV_PAGE_ENABLEDfromlocal.properties;MainActivitytoggles test page visibility usingBuildConfig.DEV_PAGE_ENABLEDEventRecordextensionWritten by Cursor Bugbot for commit 80d2b85. This will update automatically on new commits. Configure here.