forked from quarck/CalendarNotification
-
Notifications
You must be signed in to change notification settings - Fork 1
feat: notification ringtone and settings overhaul #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
williscool
merged 3 commits into
master
from
feat/notification_ringtone_and_settings_overhaul
Jan 3, 2026
Merged
feat: notification ringtone and settings overhaul #148
williscool
merged 3 commits into
master
from
feat/notification_ringtone_and_settings_overhaul
Jan 3, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41d9a9f to
e4dda34
Compare
Code Coverage Report
Files
|
📊 Code Coverage Summary
|
📊 Code Coverage Summary
|
Android 8+: Tapping "Notification Ringtone" opens the system channel settings where users can configure the sound Android 7.x: Continues to use the ringtone picker (existing behavior) System settings: Now shows channels organized into Main, Alarm, and Silent groups instead of all under "Other"
80610a2 to
7af0b41
Compare
📊 Code Coverage Summary
|
📊 Code Coverage Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android 8+: Tapping "Notification Ringtone" opens the system channel
settings where users can configure the sound
Android 7.x: Continues to use the ringtone picker (existing behavior)
System settings: Now shows channels organized into Main, Alarm, and
Silent groups instead of all under "Other"
fixes #145 fixes #135
Note
Modernizes notification sounds and channel structure.
group_main,group_alarm,group_silentand assigns existing channels accordingly inNotificationChannels; creates groups before channelsNotificationSoundPreferencethat on Android 8+ opens systemACTION_CHANNEL_NOTIFICATION_SETTINGSfor a givenchannelId, and on Android 7.x uses the ringtone picker; updates summaries to show current soundNotificationSettingsFragmentXandReminderSettingsFragmentXto useNotificationSoundPreference, handle activity results, refresh summaries on resume, and add links to system app notification settingsgetChannelSoundUriandgetChannelSoundTitleto read channel sound infonotification_preferences_x.xml,reminder_preferences_x.xml) and resources (attrs.xml,strings.xml) for new preference, channel groups, and labelsWritten by Cursor Bugbot for commit 7af0b41. This will update automatically on new commits. Configure here.