Skip to content

Conversation

@williscool
Copy link
Owner

@williscool williscool commented Jan 3, 2026

Android 8+: Tapping "Notification Ringtone" opens the system channel
settings where users can configure the sound

Android 7.x: Continues to use the ringtone picker (existing behavior)
System settings: Now shows channels organized into Main, Alarm, and
Silent groups instead of all under "Other"

fixes #145 fixes #135


Note

Modernizes notification sounds and channel structure.

  • Adds channel groups group_main, group_alarm, group_silent and assigns existing channels accordingly in NotificationChannels; creates groups before channels
  • Introduces NotificationSoundPreference that on Android 8+ opens system ACTION_CHANNEL_NOTIFICATION_SETTINGS for a given channelId, and on Android 7.x uses the ringtone picker; updates summaries to show current sound
  • Updates NotificationSettingsFragmentX and ReminderSettingsFragmentX to use NotificationSoundPreference, handle activity results, refresh summaries on resume, and add links to system app notification settings
  • Adds helper APIs getChannelSoundUri and getChannelSoundTitle to read channel sound info
  • Updates XML (notification_preferences_x.xml, reminder_preferences_x.xml) and resources (attrs.xml, strings.xml) for new preference, channel groups, and labels
  • Expands Robolectric tests to verify group creation/assignments and sound helper behavior, keeping channel creation idempotent

Written by Cursor Bugbot for commit 7af0b41. This will update automatically on new commits. Configure here.

@williscool williscool force-pushed the feat/notification_ringtone_and_settings_overhaul branch from 41d9a9f to e4dda34 Compare January 3, 2026 19:53
@github-actions
Copy link

github-actions bot commented Jan 3, 2026

Code Coverage Report

Overall Project 32.63% -0.45% 🍏
Files changed 47.27%

Module Coverage
app 44.06% -0.47%
x8664Debug 21.44% -0.43%
Files
Module File Coverage
app NotificationChannels.kt 89.28% -7.54% 🍏
NotificationSoundPreference.kt 34.15% -58.23%
NotificationSettingsFragmentX.kt 17.84% -37.84%
ReminderSettingsFragmentX.kt 0% -37.96%
x8664Debug NotificationChannels.kt 92.17% -7.83% 🍏
NotificationSoundPreference.kt 34.76% -57.62%
ReminderSettingsFragmentX.kt 24.09% -23.36%
NotificationSettingsFragmentX.kt 17.84% -37.84%

@github-actions
Copy link

github-actions bot commented Jan 3, 2026

📊 Code Coverage Summary

Coverage Type Coverage
Overall null
Changed Files 100

View detailed coverage report

@github-actions
Copy link

github-actions bot commented Jan 3, 2026

Build artifacts for PR #148 (commit a89c806) are available:

You can download these artifacts from the "Artifacts" section of the workflow run.

@github-actions
Copy link

github-actions bot commented Jan 3, 2026

📊 Code Coverage Summary

Coverage Type Coverage
Overall 21.45
Changed Files 50.3

View detailed coverage report

Android 8+: Tapping "Notification Ringtone" opens the system channel
settings where users can configure the sound

Android 7.x: Continues to use the ringtone picker (existing behavior)
System settings: Now shows channels organized into Main, Alarm, and
Silent groups instead of all under "Other"
@github-actions
Copy link

github-actions bot commented Jan 3, 2026

Build artifacts for PR #148 (commit b528966) are available:

You can download these artifacts from the "Artifacts" section of the workflow run.

@williscool williscool force-pushed the feat/notification_ringtone_and_settings_overhaul branch from 80610a2 to 7af0b41 Compare January 3, 2026 21:25
@github-actions
Copy link

github-actions bot commented Jan 3, 2026

Build artifacts for PR #148 (commit 554f4bc) are available:

You can download these artifacts from the "Artifacts" section of the workflow run.

@github-actions
Copy link

github-actions bot commented Jan 3, 2026

📊 Code Coverage Summary

Coverage Type Coverage
Overall 30.91
Changed Files 47.79

View detailed coverage report

@williscool williscool merged commit 69f9b9d into master Jan 3, 2026
15 checks passed
@github-actions
Copy link

github-actions bot commented Jan 3, 2026

📊 Code Coverage Summary

Coverage Type Coverage
Overall 32.63
Changed Files 47.79

View detailed coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App isn't using the set notification sound after upgrading to 9.4.0 Bug: All Notifications Types categorized under other

2 participants