feat!: dismiss from reschedule confirmations #73

williscool · 2025-04-10T23:36:03Z

TODO

I would exclude reccuring events from this its hard to tell if you are dismissing the right one (we look ahead a year and another part of the codebase always picks the latest event so that could mean we dissmiss based on a future version of a reccuring event) will handle in Fast Follows: we need to exclude recurring events from Reschedule Confirmations dismissals #81
we should documetn (called it ! lol alter publication powersync add table public.reschedule_confirmations)

feat: dismiss from reschedule confirmations!
feat: ids array over the bridge!
feat: json over the bridge!
feat: stub for in the app
feat: events all the way to the app side!
feat: maybe dismiss from react native!
feat: updated dissmiss message
feat: safe dismiss in bulk
test: tests!
chore: interface
test: event dissmiss tests run
test: ignore orig tests for now

github-actions · 2025-04-10T23:58:48Z

Build artifacts for this PR are available:

You can download these artifacts from the "Artifacts" section of the workflow run.

github-actions · 2025-04-11T00:03:52Z

Build artifacts for this PR are available:

You can download these artifacts from the "Artifacts" section of the workflow run.

github-actions · 2025-04-11T00:14:51Z

Code Coverage Report

Overall Project	13.77% `-1.19%`	❌
Files changed	28.66%	❌

Module	Coverage
app	26.25% `-0.72%`	❌
x8664Debug	1.43% `-1.66%`	❌

Files

Module	File	Coverage
app	EventDismissResult.kt	90.79% `-9.21%`	🍏
	DismissedEventAlertRecord.kt	57.69% `-12.5%`	🍏
	ApplicationController.kt	37.22% `-8.19%`	❌
	RescheduleConfirmationsBroadcastReceiver.kt	0%	❌
	DismissedEventListAdapter.kt	0% `-3.04%`	❌
x8664Debug	DismissedEventListAdapter.kt	0% `-3.04%`	❌
	RescheduleConfirmationsBroadcastReceiver.kt	0%	❌
	ApplicationController.kt	0% `-19.55%`	❌
	EventDismissResult.kt	0%	❌
	DismissedEventAlertRecord.kt	0% `-37.5%`	❌

github-actions · 2025-04-11T00:14:54Z

📊 Code Coverage Summary

Type	Coverage
Line	13.53
Branch

View detailed coverage report

github-actions · 2025-04-11T00:17:03Z

Build artifacts for this PR are available:

You can download these artifacts from the "Artifacts" section of the workflow run.

github-actions · 2025-04-11T00:21:22Z

📊 Code Coverage Summary

Type	Coverage
Line	13.52
Branch

View detailed coverage report

github-actions · 2025-04-11T00:34:19Z

📊 Code Coverage Summary

Type	Coverage
Line	13.49
Branch

View detailed coverage report

github-actions · 2025-04-11T01:10:12Z

Build artifacts for this PR are available:

You can download these artifacts from the "Artifacts" section of the workflow run.

github-actions · 2025-04-11T01:26:04Z

📊 Code Coverage Summary

Type	Coverage
Line	13.98
Branch

View detailed coverage report

github-actions · 2025-04-11T01:52:28Z

Build artifacts for PR #73 (commit 932424f) are available:

You can download these artifacts from the "Artifacts" section of the workflow run.

github-actions · 2025-04-11T02:07:48Z

📊 Code Coverage Summary

Type	Coverage
Line	13.87
Branch

View detailed coverage report

App/SetupSync.tsx

android/app/src/main/java/com/github/quarck/calnotify/app/ApplicationController.kt

.../src/androidTest/java/com/github/quarck/calnotify/dismissedeventsstorage/EventDismissTest.kt

android/app/src/main/res/values/strings.xml

lib/powersync/Schema.tsx

modules/my-module/android/build.gradle

modules/my-module/android/src/main/java/expo/modules/mymodule/JsRescheduleConfirmationObject.kt

modules/my-module/android/src/main/java/expo/modules/mymodule/MyModule.kt

.github/workflows/actions.yml

github-actions · 2025-04-14T01:08:26Z

Build artifacts for PR #73 (commit 238f42e) are available:

You can download these artifacts from the "Artifacts" section of the workflow run.

github-actions · 2025-04-14T01:23:38Z

📊 Code Coverage Summary

Type	Coverage
Line	0.72
Branch

View detailed coverage report

modules/my-module/index.ts

...rc/main/java/com/github/quarck/calnotify/dismissedeventsstorage/DismissedEventAlertRecord.kt

init commit

github-actions · 2025-04-25T01:28:26Z

Build artifacts for PR #73 (commit 17297f2) are available:

You can download these artifacts from the "Artifacts" section of the workflow run.

github-actions · 2025-04-25T01:58:06Z

📊 Code Coverage Summary

Coverage Type	Coverage
Overall	13.63
Changed Files	13.93

View detailed coverage report

github-actions · 2025-04-25T03:37:29Z

Build artifacts for PR #73 (commit 2a11e61) are available:

You can download these artifacts from the "Artifacts" section of the workflow run.

github-actions · 2025-04-25T03:56:58Z

Build artifacts for PR #73 (commit 23d07b0) are available:

You can download these artifacts from the "Artifacts" section of the workflow run.

github-actions · 2025-04-25T04:07:02Z

📊 Code Coverage Summary

Coverage Type	Coverage
Overall	13.64
Changed Files	13.93

View detailed coverage report

github-actions · 2025-04-25T04:26:35Z

📊 Code Coverage Summary

Coverage Type	Coverage
Overall	13.73
Changed Files	14.18

View detailed coverage report

github-actions · 2025-04-25T04:43:42Z

Build artifacts for PR #73 (commit 377bbe5) are available:

You can download these artifacts from the "Artifacts" section of the workflow run.

github-actions · 2025-04-25T05:13:32Z

📊 Code Coverage Summary

Coverage Type	Coverage
Overall	13.71
Changed Files	14.18

View detailed coverage report

want to have a broader look later

its not trivial. the current ui always gets the context about things from the dimissed events db to display I thought the strings were calucluated once then stored. dont know why :D

github-actions · 2025-04-25T06:45:00Z

Build artifacts for PR #73 (commit 31a1798) are available:

You can download these artifacts from the "Artifacts" section of the workflow run.

github-actions · 2025-04-25T06:54:45Z

📊 Code Coverage Summary

Coverage Type	Coverage
Overall	13.77
Changed Files	15.47

View detailed coverage report

android/app/src/main/java/com/github/quarck/calnotify/app/ApplicationController.kt

williscool · 2025-04-29T03:39:27Z

just saving some notes from working on this

TODO

I would exclude reccuring events from this its hard to tell if you are dismissing the right one (we look ahead a year and another part of the codebase always picks the latest event so that could mean we dissmiss based on a future version of a reccuring event)
we should documetn (called it ! lol alter publication powersync add table public.reschedule_confirmations)

done

issmiss events it finds cannot be undone

then it filters table for isInFuture and dissmiss!

DONT FORGET TO REMOVE THE DEV PAGE FROM THE BUILD THAT GOES ON YOUR PHONE!!!!

follow up clean uip

add a button that syncs schduler confirmations to local powesync db (it should be one way from powesync through the supabase resschduler confirmations table)

my-module consumes that put it behide a safe place that says will d

override fun dismissEvent(

context: Context,

dismissType: EventDismissType,

eventId: Long,

instanceStartTime: Long,

notificationId: Int,

notifyActivity: Boolean

) {

witht he eventId and instanceStartTime

should be ready for errors where they dont exist

ponly place I worry about snag is powersync setup. does teh pucliation name matter?

(called it ! lol alter publication powersync add table public.reschedule_confirmations)

notes dont forget to setup supabase table to be realtime and broadcast cahnges in their tabel (i dd it late night 4-9)

dont forget you can hardcode a record in reschuler confrimations to use also we can just locally hard code theid and call it from the js side of the bridge

williscool changed the title ~~feat/dismiss from reschedule confirmations~~ feat!: dismiss from reschedule confirmations Apr 10, 2025

williscool commented Apr 11, 2025

View reviewed changes

App/SetupSync.tsx Outdated Show resolved Hide resolved

android/app/src/main/java/com/github/quarck/calnotify/app/ApplicationController.kt Outdated Show resolved Hide resolved

williscool commented Apr 11, 2025

View reviewed changes

.../src/androidTest/java/com/github/quarck/calnotify/dismissedeventsstorage/EventDismissTest.kt Show resolved Hide resolved

williscool commented Apr 11, 2025

View reviewed changes

.../src/androidTest/java/com/github/quarck/calnotify/dismissedeventsstorage/EventDismissTest.kt Show resolved Hide resolved

williscool commented Apr 11, 2025

View reviewed changes

android/app/src/main/res/values/strings.xml Show resolved Hide resolved

williscool commented Apr 11, 2025

View reviewed changes

lib/powersync/Schema.tsx Show resolved Hide resolved

williscool commented Apr 11, 2025

View reviewed changes

modules/my-module/android/build.gradle Show resolved Hide resolved

williscool commented Apr 11, 2025

View reviewed changes

modules/my-module/android/src/main/java/expo/modules/mymodule/JsRescheduleConfirmationObject.kt Show resolved Hide resolved

williscool commented Apr 11, 2025

View reviewed changes

modules/my-module/android/src/main/java/expo/modules/mymodule/MyModule.kt Show resolved Hide resolved

williscool commented Apr 11, 2025

View reviewed changes

modules/my-module/android/src/main/java/expo/modules/mymodule/MyModule.kt Outdated Show resolved Hide resolved

williscool commented Apr 12, 2025

View reviewed changes

.github/workflows/actions.yml Show resolved Hide resolved

williscool commented Apr 17, 2025

View reviewed changes

modules/my-module/index.ts Outdated Show resolved Hide resolved

williscool commented Apr 17, 2025

View reviewed changes

...rc/main/java/com/github/quarck/calnotify/dismissedeventsstorage/DismissedEventAlertRecord.kt Show resolved Hide resolved

williscool added 4 commits April 23, 2025 07:04

feat: dismiss from reschedule confirmations!

af20c58

init commit

feat: ids array over the bridge!

01075cc

feat: json over the bridge!

7bf3d1c

feat: stub for in the app

fae32ac

williscool added 2 commits April 25, 2025 03:29

fix: some more codespace fixes

b363fc0

ci: more codespace stuff

31651d0

ci: more better setup_github_codespace

96e94a7

ci: more better codespace

9cca6fc

williscool added 9 commits April 25, 2025 06:35

fix: metro bundler type warning

8cdcef1

fix: vscode settings didnt want

669c8e3

feat: safeDismissEventsFromRescheduleConfirmations

65c3ff6

test: safeDismissEventsFromRescheduleConfirmations

381683d

test: more safeDismissEventsFromRescheduleConfirmations

4d26b95

test: all but 3 pass

4605eeb

test: testSafeDismissEventsFromRescheduleConfirmations almost there

4fd8bab

test: db mocking shortcomings still there

7cec40f

want to have a broader look later

docs: on showing time of reschedule to

7345bf0

its not trivial. the current ui always gets the context about things from the dimissed events db to display I thought the strings were calucluated once then stored. dont know why :D

williscool commented Apr 25, 2025

View reviewed changes

android/app/src/main/java/com/github/quarck/calnotify/app/ApplicationController.kt Show resolved Hide resolved

williscool mentioned this pull request Apr 25, 2025

Fast Follows: we need to exclude recurring events from Reschedule Confirmations dismissals #81

Closed

williscool enabled auto-merge (squash) April 25, 2025 07:25

williscool mentioned this pull request Apr 25, 2025

Testing #61

Closed

20 tasks

williscool merged commit da17b07 into master Apr 25, 2025
10 checks passed

williscool mentioned this pull request Apr 28, 2025

fix: safeDismissEventsFromRescheduleConfirmations fast follows #82

Merged

2 tasks

feat!: dismiss from reschedule confirmations #73

feat!: dismiss from reschedule confirmations #73

Uh oh!

Conversation

williscool commented Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO

Uh oh!

github-actions bot commented Apr 10, 2025

Uh oh!

github-actions bot commented Apr 11, 2025

Uh oh!

github-actions bot commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Report

Uh oh!

github-actions bot commented Apr 11, 2025

📊 Code Coverage Summary

Uh oh!

github-actions bot commented Apr 11, 2025

Uh oh!

github-actions bot commented Apr 11, 2025

📊 Code Coverage Summary

Uh oh!

github-actions bot commented Apr 11, 2025

📊 Code Coverage Summary

Uh oh!

github-actions bot commented Apr 11, 2025

Uh oh!

github-actions bot commented Apr 11, 2025

📊 Code Coverage Summary

Uh oh!

github-actions bot commented Apr 11, 2025

Uh oh!

github-actions bot commented Apr 11, 2025

📊 Code Coverage Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Apr 14, 2025

Uh oh!

github-actions bot commented Apr 14, 2025

📊 Code Coverage Summary

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Apr 25, 2025

Uh oh!

github-actions bot commented Apr 25, 2025

📊 Code Coverage Summary

Uh oh!

github-actions bot commented Apr 25, 2025

Uh oh!

github-actions bot commented Apr 25, 2025

Uh oh!

github-actions bot commented Apr 25, 2025

📊 Code Coverage Summary

Uh oh!

github-actions bot commented Apr 25, 2025

📊 Code Coverage Summary

Uh oh!

github-actions bot commented Apr 25, 2025

Uh oh!

github-actions bot commented Apr 25, 2025

📊 Code Coverage Summary

Uh oh!

github-actions bot commented Apr 25, 2025

Uh oh!

github-actions bot commented Apr 25, 2025

📊 Code Coverage Summary

Uh oh!

williscool commented Apr 10, 2025 •

edited

Loading

github-actions bot commented Apr 11, 2025 •

edited

Loading