fix(infra): add ChatApiAgentIdentityId to Reporting.Api params

[willvelida]

Summary

Add the missing chatApiAgentIdentityId parameter to the Reporting.Api dev Bicep params file. This restores Chat.Api's ability to authenticate with Reporting.Api for report generation.

Root Cause

PR #274 extended the Reporting.Api authorization policy to accept multiple agent identity callers via azp claim validation. The chatApiAgentIdentityId Bicep parameter defaults to '', and the App Configuration key Biotrackr:ChatApiAgentIdentityId was never provisioned via IaC. Without this key, the authorization policy rejects Chat.Api requests with 403 Forbidden — the JWT is valid but the azp claim doesn't match any configured caller ID.

Evidence

• Chat.Api dependency telemetry: POST /api/reports/generate → 403 Forbidden
• Container logs confirm healthy startup (app on port 8080, sidecar on port 4321)
• Biotrackr:ChatApiAgentIdentityId confirmed missing from Azure App Configuration
• Biotrackr:ReportingSvcAgentIdentityId was set (from PR feat(reporting-svc): add scheduled health summary service #276), so the policy only accepted Reporting.Svc

Changes

Modified

• infra/apps/reporting-api/main.dev.bicepparam — Added param chatApiAgentIdentityId = '707307f7-ffc4-4744-a66b-19fa942c1c10'

Validation

• Bicep param references existing parameter definition in main.bicep (line 50)
• Conditional App Config deployment at line 382 will create the key when chatApiAgentIdentityId is not empty
• No code changes required — authorization policy logic is correct

[github-advanced-security]

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

• The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
• Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
• You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

[Copilot]

Pull request overview

This PR restores Chat.Api → Reporting.Api agent-to-agent authentication by ensuring the Reporting.Api dev deployment provisions the missing Biotrackr:ChatApiAgentIdentityId App Configuration value (used for azp claim validation).

Changes:

• Add chatApiAgentIdentityId to infra/apps/reporting-api/main.dev.bicepparam with the dev Chat.Api agent identity GUID.

[github-actions]

Package	Line Rate	Branch Rate	Health
Biotrackr.Reporting.Api	73%	62%	➖
Summary	73% (451 / 621)	62% (99 / 159)	➖

Minimum allowed line rate is 60%