Change Orientation2D type to Rotary#264
Merged
waynemwashuma merged 5 commits intowimaengine:devfrom Sep 20, 2025
Merged
Conversation
Ensure results are copied to calling rotary
Orientation2D type to Rotary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Refactors the entire rotation and orientation system to use quaternion-like
Rotaryinstead of raw angles for 2D rotations. This provides more robust mathematical operations, eliminates angle wrapping issues, and creates consistency between 2D and 3D rotation handling.Solution
Orientation2Dnow usesRotaryinstead ofAngleRotary.slerp()for smooth interpolationShowcase
The new Rotary-based system provides more robust rotation handling:
Migration Guide
Orientation2Dis no longer anAnglebut aRotary.Orientation operations should be switched from using number based angles toRotaryoperations.For examole:Checklist