feat: MCP tools refactor - replace grove_contribute with per-kind tools#170
Open
sungdark wants to merge 1 commit intowindoliver:mainfrom
Open
feat: MCP tools refactor - replace grove_contribute with per-kind tools#170sungdark wants to merge 1 commit intowindoliver:mainfrom
sungdark wants to merge 1 commit intowindoliver:mainfrom
Conversation
Implements grove issue windoliver#169: force structured contribution input. Changes: - Remove grove_contribute (allowed agents to bypass required fields) - Add grove_submit_work: requires summary + artifacts (blocks agents without file hashes) - Add grove_submit_review: requires targetCid + summary + scores - Update grove_discuss: notes that grove_send_message is merged (use tags for @mentions) - Deprecate grove_bounty_claim (agents should use grove_claim instead) - Update spawn-manager.ts agent instructions to reference new tool names - Update all related tests (contributions.test.ts, tools.test.ts, server.test.ts, server.integration.test.ts) - All 177 tests pass Receipt address: eB51DWp1uECrLZRLsE2cnyZUzfRWvzUzaJzkatTpQV9
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements grove issue #169: force structured contribution input to prevent agents from bypassing required fields.
Changes
Problem
The old
grove_contributetool accepted all fields as optional, allowing agents to submit reviews without scores, or work without artifacts. This broke the frontier ranking and made it impossible for agents to review code they couldn't see.Solution
grove_contribute- the generic escape hatchgrove_submit_work- requiressummary+artifacts(blocks agents without file hashes)grove_submit_review- requirestargetCid+summary+scores(frontier ranking now always has scores)grove_discussdescription - notes thatgrove_send_messageis merged (use tags for @mentions)grove_bounty_claim- agents should usegrove_claimdirectlyAgent Instructions Updated
src/tui/spawn-manager.tsCLAUDE.md template to reference new tool namesTests
contributions.test.tstools.test.ts,server.test.ts,server.integration.test.tsAcceptance Criteria (from issue #169)
grove_submit_worksummary,artifactsgrove_contribute(kind=work)grove_submit_reviewtargetCid,summary,scoresgrove_review+grove_contribute(kind=review)grove_discusssummarygrove_contribute(kind=discussion)+grove_send_messagegrove_reproducetargetCid,result,summarygrove_contribute(kind=reproduction)grove_doneagentgrove_contribute(context.done=true)Bounty Payment
收款地址：eB51DWp1uECrLZRLsE2cnyZUzfRWvzUzaJzkatTpQV9