Skip to content

Add OS-native secret backends: keychain, secretservice, and wincred #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
winhowes merged 2 commits into from
Apr 21, 2026
Merged

Add OS-native secret backends: keychain, secretservice, and wincred #628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db9d57b
Use non-windows build-tagged wincred unsupported test
winhowes Apr 21, 2026
a11a466
Merge branch 'main' into codex/add-secret-plugins-for-key-management-…
winhowes Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions app/secrets/plugins/wincred/load_other_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
//go:build !windows

package plugins

import "testing"

func TestLoadWindowsCredentialUnsupported(t *testing.T) {
if _, err := loadWindowsCredential("target", "raw"); err == nil {
t.Fatal("expected unsupported-platform error")
}
}
10 changes: 0 additions & 10 deletions app/secrets/plugins/wincred/plugin_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package plugins
import (
"context"
"encoding/binary"
"runtime"
"testing"
"unicode/utf16"
)
Expand All @@ -29,15 +28,6 @@ func TestWinCredPluginLoad(t *testing.T) {
}
}

func TestLoadWindowsCredentialUnsupported(t *testing.T) {
if runtime.GOOS == "windows" {
t.Skip("non-windows unsupported-path test")
}
if _, err := loadWindowsCredential("target", "raw"); err == nil {
t.Fatal("expected unsupported-platform error")
}
}

func TestWinCredPluginLoadInvalidID(t *testing.T) {
p := winCredPlugin{}
if _, err := p.Load(context.Background(), "#utf8"); err == nil {
Expand Down
Loading