Add descriptionFrom support for nested properties #1128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for JSON columns descriptionFrom: name descriptionFrom: json.name descriptionFrom: json[name]
Member
|
@AIC-BV could you add a unit test for this? |
Contributor
Author
|
I don't know how to do this 😬 |
LukeTowers
reviewed
Sep 26, 2024
| $this->descriptionFrom = str_replace(['[', ']'], ['.', ''], $this->descriptionFrom); | ||
| } | ||
|
|
||
| return data_get($this->relationModel, $this->descriptionFrom); |
Member
There was a problem hiding this comment.
@jaxwilko @bennothommo any thoughts on assigning the modified value back to the local property instead of using a scoped variable at this point? I'm slightly concerned that this current approach causes getDescriptionValue() to have a secondary effect of modifying the value of $this->descriptionFrom in some cases.
bennothommo
added
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for JSON columns
descriptionFrom: name
descriptionFrom: json.name
descriptionFrom: json[name]