Skip to content

Conversation

@mjauvin
Copy link
Member

@mjauvin mjauvin commented May 17, 2024

Add the following events for the primary RelationController widgets:

- relation.extendViewWidget
- relation.extendManageWidget
- relation.extendPivotWidget

Questions:

  • do we need the global events?
  • do we need the following events:
   - relation.extendViewFilterWidget
   - relation.extendManageFilterWidget
   - relation.extendRefreshResults
   - relation.extendConfig

Note:

I didn't add parenthesis around the arguments in the handler method signatures because I find this is a pain when copy/pasting an example to get you started as they need to be removed.

I think we should do the same for the other events examples elsewhere in the codebase.

@mjauvin mjauvin added the enhancement PRs that implement a new feature or substantial change label May 17, 2024
@mjauvin mjauvin added this to the 1.2.7 milestone May 17, 2024
@mjauvin mjauvin self-assigned this May 17, 2024
@mjauvin mjauvin marked this pull request as draft May 17, 2024 13:57
@mjauvin mjauvin changed the title Add extension events for the main relation widgets WIP: Add extension events for the main relation widgets May 17, 2024
@mjauvin mjauvin marked this pull request as ready for review May 17, 2024 15:08
@LukeTowers LukeTowers modified the milestones: 1.2.7, 1.2.8 Jul 22, 2024
@mjauvin
Copy link
Member Author

mjauvin commented Oct 11, 2024

Any feedback on this welcome.

@LukeTowers LukeTowers added the needs review Issues/PRs that require a review from a maintainer label Feb 13, 2025
@LukeTowers LukeTowers modified the milestones: 1.2.8, 1.3.0 Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement PRs that implement a new feature or substantial change needs review Issues/PRs that require a review from a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants