Add model:prune console command #1263
Conversation
mjauvin
added
enhancement
| $models[] = static::findCoreModels(); | ||
| $models[] = static::findActivePluginsModels(); | ||
|
|
||
| return collect($models)->flatten()->all(); |
There was a problem hiding this comment.
Are we doing any sort of checking to make sure the classes are actual model classes?
There was a problem hiding this comment.
@LukeTowers But I do search only under /models/ folders
There was a problem hiding this comment.
Are we doing any sort of checking to make sure the classes are actual model classes?
Any suggestions ?
There was a problem hiding this comment.
@mjauvin if the intention is to find out if it's a model without loading it, you'll have to use something like PHP Parser to statically analyze the file.
There was a problem hiding this comment.
@bennothommo I think searching for all class files under models is good enough for the purpose, more logic can be added by the code using the ModelFinder helper once it gets the list of class files as this is more efficient.
|
@jaxwilko random thought: This could be related to our work on the extension management refactoring where we could make it so that the extension managers could have an API for searching for specific types of classes / files under them (i.e. model classes, components, CLI commands, etc) to make these sorts of use cases easier to implement. |
No description provided.