-
Notifications
You must be signed in to change notification settings - Fork 238
Fix/camera decoding issue [WPB-22425] #9370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EnricoSchw
wants to merge
7
commits into
dev
Choose a base branch
from
fix/camera-decoding-issue-WPB-22425
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation attempted to enable/disable hardware acceleration based on runtime GPU detection, which is ineffective and occurs too late in Electron’s startup lifecycle.
Introduced logic to disable GPU-based hardware acceleration for affected HP EliteBook 840 G7 models during app startup to address known issues.
…rdware acceleration
…device check function
Adjusted `wmic` command path to explicitly use the `SystemRoot` environment variable, ensuring compatibility across Windows systems.
Included detailed comments explaining the rationale behind using a fixed `wmic` command with absolute path, mitigating risks related to command injection or privilege escalation.
Contributor
Author
|
@emil-wire Could you, please review this line |
|
nkaramarko
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Pull Request
Summary
This change improves camera stability on HP devices by disabling hardware acceleration early during application startup.
We identified a known issue affecting HP laptops/desktops when using Electron (Chromium) together with MJPEG camera streams. In these cases, GPU-accelerated video decoding can lead to partially gray or corrupted video frames and unstable frame rates.
To mitigate this, hardware acceleration is now disabled before Chromium initialization on HP devices only. The detection is based on the system manufacturer and runs synchronously during startup, ensuring the correct media pipeline is selected.
This approach prioritizes stability over GPU acceleration and avoids known Intel/Chromium MJPEG decode issues while keeping the change limited in scope.
Key points
Security Checklist (required)
Standards Acknowledgement (required)
Screenshots or demo (if the user interface changed)
Notes for reviewers