Skip to content

Conversation

@aweiss-dev
Copy link
Member

@aweiss-dev aweiss-dev commented Jan 21, 2026

BugWPB-20719 [Desktop] Wire on Windows unable to sign in via SSO

Pull Request

Summary

This pull request updates several dependencies to their latest versions, improves compatibility with ES modules, and includes minor code and type safety improvements. The most significant changes are grouped below:

Dependency Updates:

  • Upgraded multiple dependencies in package.json, including core packages like electron (to 40.0.0), electron-dl (to 4.0.0), @wireapp/react-ui-kit, and various development dependencies, ensuring better compatibility, security, and access to new features.

ES Module and Dynamic Import Compatibility:

  • Replaced static import of electron-dl with a dynamic import() in electron/src/main.ts, allowing compatibility with ES modules and the updated version of electron-dl.
  • Updated dynamic import path for the context menu preload script to use the .js extension in electron/src/preload/preload-webview.ts, ensuring compatibility with module resolution changes.

Type Safety and Code Quality Improvements:

  • Improved type safety in electron/src/settings/ConfigurationPersistence.ts by explicitly casting the default value in the restore method.
  • Specified the type of the middlewares array in electron/renderer/src/configureStore.ts for better type checking.

Import Cleanups:

  • Consolidated and cleaned up imports from @wireapp/react-ui-kit in electron/renderer/src/components/WebView/Webview.tsx for improved code clarity.

Security Checklist (required)

  • External inputs are validated & sanitized on client and/or server where applicable.
  • API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
  • No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
  • Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Standards Acknowledgement (required)


Screenshots or demo (if the user interface changed)

Notes for reviewers

  • Trade-offs:
  • Follow-ups (linked issues):
  • Linked PRs (e.g. web-packages):

@aweiss-dev aweiss-dev changed the base branch from dev to staging January 21, 2026 09:14
@sonarqubecloud
Copy link

Copy link
Contributor

@V-Gira V-Gira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants