Skip to content

Fix/parse viewer namespaced mathml #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: release/v8.14.1
Choose a base branch
from
+9 −1
Open

Fix/parse viewer namespaced mathml #1122

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2237ae2
fix(viewer): improve namespaced MathML element detection
jguillen-at-wiris Oct 29, 2025
f727a26
chore: linter fixes
jguillen-at-wiris Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/viewer/src/mathml.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,15 @@ export async function renderMathML(properties: Properties, root: HTMLElement): P

decodeSafeMathML(root, properties.ignored_containers);

for (const mathElement of [...root.getElementsByTagName("math")]) {
// Fixed to get all possible math elements, including namespaced ones.
const allMathElements = [
...root.getElementsByTagName("math"), // Standard <math>
...root.getElementsByTagNameNS("*", "math"), // Any valid namespaced math
...root.querySelectorAll("m\\:math"), // CSS: <m:math> (literal colon)
...root.querySelectorAll("mml\\:math"), // CSS: <mml:math> (literal colon)
];

for (const mathElement of allMathElements) {
const mml = serializeHtmlToXml(mathElement.outerHTML);
try {
let imgSource;
Expand Down
Loading