Improve viewer handling errors #984
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carla-at-wiris
requested review from
a user,
jgonzalez-at-wiris,
psala-at-wiris,
usantos-at-wiris and
xjiang-at-wiris
usantos-at-wiris
previously approved these changes
Jun 28, 2024
xjiang-at-wiris
previously approved these changes
Jul 3, 2024
jgonzalez-at-wiris
previously approved these changes
Jul 3, 2024
Taskid 48497
carla-at-wiris
dismissed stale reviews from jgonzalez-at-wiris, xjiang-at-wiris, and usantos-at-wiris
via
4937e2f
psala-at-wiris
approved these changes
Jul 8, 2024
Contributor
psala-at-wiris
left a comment
psala-at-wiris
left a comment
There was a problem hiding this comment.
Looks perfect after las changes!
jgonzalez-at-wiris
previously approved these changes
Jul 9, 2024
xjiang-at-wiris
dismissed
jgonzalez-at-wiris’s stale review
The base branch was changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improved the way we handle the errors and some other minor stuff.
This is a side development due to the fact that there was appearing a 404 console error that we did not know how to handle.
Steps to reproduce
Validate that the code makes sense.
Try out the viewer demo and verify that it works as expected.
#taskid 48497