Skip to content
This repository was archived by the owner on Feb 5, 2026. It is now read-only.

Conversation

@jemilezzet
Copy link
Contributor

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a minimum bid requirement (minTokensPerBidder) to the Permitter system and removes the per-permit maxBidAmount field, simplifying the bid validation logic to rely solely on the global maxTokensPerBidder cap.

Changes:

  • Added minTokensPerBidder parameter to enforce a minimum bid amount per transaction
  • Removed maxBidAmount from the Permit struct, streamlining to only include bidder and expiry
  • Updated EIP-712 typehash to reflect the simplified Permit structure

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Permitter.sol Adds minTokensPerBidder validation, removes maxBidAmount from Permit struct, simplifies personal cap checking
src/interfaces/IPermitter.sol Adds BidBelowMinimum and MinTokensExceedsMaxTokens errors, removes maxBidAmount from Permit struct, adds minTokensPerBidder getter
src/PermitterFactory.sol Adds minTokensPerBidder parameter to factory methods and events
src/interfaces/IPermitterFactory.sol Adds minTokensPerBidder to factory interface and events
test/Permitter.t.sol Updates all test signatures to remove maxBidAmount, adds comprehensive tests for minimum bid enforcement
test/PermitterFactory.t.sol Updates all factory calls to include minTokensPerBidder parameter
test/Integration.t.sol Updates integration tests to use simplified permit signatures
test/Fuzz.t.sol Updates fuzz tests with minimum bid constraints and simplified signatures
test/ExploitTests.t.sol Updates exploit tests to use new permit structure
.mcp.json Adds MCP server configuration
.gitmodules Adds Claude commands submodule
.claude/commands Adds Claude commands submodule reference

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

Coverage after merging jemil/tally-9985-add-mintokensperbidder-constructor-parameter-and-remove into main will be

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Permitter.sol98.80%92.86%100%100%205, 266
   PermitterFactory.sol100%100%100%100%

Copy link

@0xpetersatoshi 0xpetersatoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jemilezzet jemilezzet merged commit fc2ba5a into main Jan 13, 2026
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants