feat(TER-345): implement core validation API bindings for Node.js#52
Closed
ericpsimon wants to merge 3 commits intomainfrom
Closed
feat(TER-345): implement core validation API bindings for Node.js#52ericpsimon wants to merge 3 commits intomainfrom
ericpsimon wants to merge 3 commits intomainfrom
Conversation
- Moved all Node.js binding files from term-guard-node/ to node/term-guard/ - Updated Cargo.toml workspace configuration - Fixed term-guard dependency path in node/term-guard/Cargo.toml - Updated GitHub Actions workflow paths - Added proper .gitignore for Node.js dependencies and build artifacts - Simplified NAPI CI workflow: - Removed matrix builds (out of scope for this project) - Single Linux build for development - Combined build and test into one job - Only upload artifacts from main branch - Updated to use npm instead of yarn - Aligned with project CI patterns
- Convert index.js to index.ts with proper TypeScript types - Convert test/index.test.js to test/index.test.ts with interfaces - Add comprehensive TypeScript type definitions in index.d.ts - Update package.json to use TypeScript compilation pipeline - Configure tsconfig.json for CommonJS module output - Update build scripts to compile TypeScript before NAPI build - Add tsx for running TypeScript tests directly - Update .gitignore and .npmignore for TypeScript workflow - Remove old JavaScript files in favor of TypeScript
- Implement ValidationSuite and Check NAPI bindings - Add DataSource abstraction for CSV, Parquet, and JSON - Create TypeScript type definitions - Add comprehensive test coverage - Enable builder pattern for Check and ValidationSuite - Support async validation execution with performance metrics Implements: TER-345
448fe13 to
3ace505
Compare
Contributor
Author
|
Closing as duplicate. This PR is now properly stacked as #55 which targets the 10-03 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements NAPI bindings for the core validation API, exposing ValidationSuite, Check, and related types to TypeScript.
Implementation Details
Core Modules Added:
src/types.rs: Type conversions and enums (Level, ConstraintStatus, ValidationResult, etc.)src/check.rs: Check and CheckBuilder with various constraint methodssrc/validation_suite.rs: ValidationSuite and builder with async run capabilitysrc/data_source.rs: DataSource abstraction supporting CSV, Parquet, and JSONsrc/lib.rs: Main NAPI module setup and exportsKey Features:
✅ ValidationSuite can be created from TypeScript
✅ Check builder pattern works in TypeScript
✅ Async run() method properly returns Promise
✅ Error handling converts Rust errors to JS exceptions
✅ TypeScript definitions are correctly generated
✅ Basic validation suite can be built and executed
TypeScript API:
Test Coverage
Linear Ticket
Implements: TER-345
🤖 Generated with Claude Code