Conversation
ydaniv
left a comment
ydaniv
left a comment
There was a problem hiding this comment.
So far reviewed animation-group, effects, and pointer-animations.
Let's fix those and continue
| "@babel/code-frame@npm:^7.10.4, @babel/code-frame@npm:^7.28.6": | ||
| version: 7.28.6 | ||
| resolution: "@babel/code-frame@npm:7.28.6" | ||
| "@babel/code-frame@npm:^7.10.4, @babel/code-frame@npm:^7.28.6, @babel/code-frame@npm:^7.29.0": |
There was a problem hiding this comment.
Looks like we have misaligned versions in the different package.json files.
I can see one is @vitejs/plugin-react.
Please see if you can dedupe those.
| expect(events).toContain('pause'); | ||
| }); | ||
|
|
||
| test('should reverse animation direction', async () => { |
There was a problem hiding this comment.
This test should also check playbackRate is -1 after reversing
| ) as HTMLElement; | ||
|
|
||
| // X-axis animation: translateX driven by horizontal mouse position | ||
| const xAxisGroup = getWebAnimation(xAxisTarget, { |
There was a problem hiding this comment.
All of the pointer fixtures use getWebAnimation(), none actually use getScrubScene() which is what we actually use for all pointer-move animations.
So none actually check the correct code path for pointer animations.
Let's correct that, so it's actually passing the correct trigger data, with different axes, using all the type of effects, etc.
2 participants
Description
Related Issue
Checklist
Screenshots / Demos
Additional Notes