Open
Conversation
Author
|
Hi. The JSONPath package is now labelled as vulnerable to Arbitrary Code Injection: https://security.snyk.io/vuln/SNYK-JS-JSONPATH-13645034 Would you consider reviewing and merging this PR now to resolve this issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to use the
asl-choice-processorin my own state machine library, and when building I was running into issues with thejsonpathdependency, specifically because it is usingrequire.resolvein a couple of places:https://github.com/search?q=repo%3Adchester%2Fjsonpath%20require.resolve&type=code
This PR replaces
jsonpathwithjsonpath-plus, which is bundled for newer versions of node and also browsers. jsonpath-plus is not a drop in replacement so I had to updatejp.query(values, inputPath)withJSONPath({path: inputPath, json: values, wrap: false}).Tests pass after changes.
Thank you for creating and maintaining this library!