Skip to content

Improve Collapsible component#268

Open
meenahoda wants to merge 5 commits intomasterfrom
improve-collapsibles
Open

Improve Collapsible component#268
meenahoda wants to merge 5 commits intomasterfrom
improve-collapsibles

Conversation

@meenahoda
Copy link
Member

@meenahoda meenahoda commented Aug 17, 2022

  • collapsible to user builder rather than constructing string template
  • add tooltip
  • add spacing
  • ability to control open/close with model

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #268 (319f7f7) into master (b989131) will decrease coverage by 0.14%.
The diff coverage is 10.71%.

@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
- Coverage   33.70%   33.56%   -0.15%     
==========================================
  Files          75       75              
  Lines        2148     2166      +18     
==========================================
+ Hits          724      727       +3     
- Misses       1424     1439      +15     
Impacted Files Coverage Δ
lib/builders/Collapsible.js 12.50% <10.71%> (+3.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@meenahoda meenahoda changed the title feat: collapsible to user builder rather than constructing string tem… Improve Collapsible component Aug 17, 2022
@meenahoda meenahoda requested a review from reecebrend August 17, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant