Skip to content

feat: re-apply PR#332 spacing on chips/badges #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
meenahoda wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: re-apply PR#332 spacing on chips/badges #334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 29 additions & 9 deletions lib/builders/Chip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
const ComponentBuilder = require('./../utils/Component-builder')
const applySpacing = require('./../utils/apply-spacing')
const { COLORS, TEXT_WHITE } = require('./../utils/color-reference')

module.exports = function (definition, options) {
Expand All @@ -14,12 +15,21 @@ module.exports = function (definition, options) {
function chipBuilder (builder, definition) {
const {
icon,
text
text,
spacing
} = definition

const chip = builder
.addTag('q-chip')
.addAttribute('class', 'q-mt-md q-mr-sm q-mb-none q-ml-none')
const span = builder.addTag('span')
const chip = span.addChildTag('q-chip')

const classes = [
'q-mr-sm',
'q-ml-none'
]

applySpacing({ source: span, spacing, classes })

// span.addAttribute('class', classes.join(' '))

if (icon) {
chip.addAttribute('icon', icon)
Expand All @@ -41,13 +51,23 @@ function chipBuilder (builder, definition) {
function badgeBuilder (builder, definition) {
const {
icon,
text
text,
spacing
} = definition

const badge = builder
.addTag('q-badge')
.addAttribute('class', 'q-mt-md q-mr-sm q-mb-none q-ml-none')
.addAttribute('multi-line', null)
const span = builder.addTag('span')
const badge = span.addChildTag('q-badge')

const classes = [
'q-mr-sm',
'q-ml-none'
]

applySpacing({ source: span, spacing, classes })

// span.addAttribute('class', classes.join(' '))

badge.addAttribute('multi-line', null)

if (icon) {
badge
Expand Down