Fix bug in updated "Remember Me" strategy (rebased)#142
Merged
Conversation
…ials due to browser persistence (failing);
…n skipping challenge due to browser persistence (resolves test failure);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #138 updated the "Remember Me" functionality to delegate setting the rememberable cookie to the OTP Credentials controller (previously, Rememberable was not working). However, the OTP Credentials controller was not updated to account for situations where the user has trusted their current browser, thereby skipping the OTP Credentials form.
This Pull Request updates the OTP Credentials controller to set the "Remember Me" value within the skip_challenge_if_trusted_browser "before_action" (in addition to the normal update action) for situations where the user is bypassing the OTP Credentials form due to browser persistence.