Skip to content

Conversation

@camilossantos2809
Copy link

@camilossantos2809 camilossantos2809 commented Nov 21, 2025

Removed the READ_MEDIA_IMAGES permission from AndroidManifest.xml so the app is not rejected during Google Play review.

Fixes #110. As mentioned in the issue comments, seems that the permission is not in use. Even with the changes introduced in version 2.3.3, the app was still rejected by Google Play.

I wasn’t able to run the example app due to Android build issues (specifically with react-native-screens), but I tested the change directly in my own app and, after removing this permission, the build was approved for the production track.

Regarding Android 13, everything continued to work after the change. I tested it on the emulator using the command:

adb shell input keyevent 120

Screenshot_1763498869

If there’s anything else that needs to be adjusted, I’m happy to update the PR.

Summary by CodeRabbit

  • Chores
    • Simplified app storage permissions to use a unified approach for accessing media files across all supported Android versions.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 21, 2025

Walkthrough

This pull request removes the READ_MEDIA_IMAGES permission entry from the Android manifest's fullMediaCapture flavor, streamlining the permission configuration to use only READ_EXTERNAL_STORAGE (constrained to SDK 32 and below). This addresses Google Play's rejection of the dual-permission setup.

Changes

Cohort / File(s) Summary
Android Permission Removal
android/src/fullMediaCapture/AndroidManifest.xml
Removed READ_MEDIA_IMAGES permission entry (minSdkVersion 33, maxSdkVersion 34); retained READ_EXTERNAL_STORAGE permission (maxSdkVersion 32).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 One permission goes away,
Google's walls no longer stay,
Simpler paths now light the way,
Android's blessing, hip hooray! ✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: removing READ_MEDIA_IMAGES permission to comply with Google Play policies, which is exactly what the changeset accomplishes.
Linked Issues check ✅ Passed The PR successfully addresses the objective from issue #110 by removing the READ_MEDIA_IMAGES permission that was causing Google Play rejection.
Out of Scope Changes check ✅ Passed The changeset contains only the removal of READ_MEDIA_IMAGES permission from AndroidManifest.xml, which is directly scoped to resolving the Google Play rejection issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d299992 and 38bd079.

📒 Files selected for processing (1)
  • android/src/fullMediaCapture/AndroidManifest.xml (0 hunks)
💤 Files with no reviewable changes (1)
  • android/src/fullMediaCapture/AndroidManifest.xml

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@wn-na
Copy link
Owner

wn-na commented Nov 24, 2025

@camilossantos2809 thanks for pr
I am currently considering this matter. I will make a decision after careful consideration as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Google is not accept permission

2 participants