Skip to content

[b/328439250] Remove NULL expectations from boolean columns #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tanclary wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[b/328439250] Remove NULL expectations from boolean columns #2

tanclary wants to merge 1 commit into from

Conversation

@tanclary
Copy link

@tanclary tanclary commented Mar 13, 2024

No description provided.

@tanclary
[b/328439250] Remove NULL expectations from boolean columns
95d844d 
Dimensions of type YESNO in LookML will never return NULL, so when we select a boolean column in the SQL Interface, we should never expect NULL.
jswett77
jswett77 reviewed Mar 13, 2024
View reviewed changes
tdvt/tdvt/exprtests/standard/expected.setup.calcs_data.txt
</schema>
<tuple>
<value>%null%</value>
</tuple>
Copy link

@jswett77 jswett77 Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with the datasets, is this removing an expected column value or row value?

Copy link
Author

@tanclary tanclary Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's removing a single cell from the expected results. you can see in the above tag the name of the column you're removing a row from.

Copy link

@Anthrino Anthrino Mar 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the info @tanclary, sorry missed checking information you added to the bug.
LGTM for the change.

Copy link
Author

@tanclary tanclary Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries thanks for looking y'all 👍

Anthrino
Anthrino reviewed Mar 13, 2024
View reviewed changes
Copy link

@Anthrino Anthrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm @tanclary, did we find a reason why Looker isn't returning these Null values?
Might be worth mentioning the reason we have to remove these from expected results.

@tanclary
Copy link
Author

tanclary commented Mar 13, 2024

Just to confirm @tanclary, did we find a reason why Looker isn't returning these Null values? Might be worth mentioning the reason we have to remove these from expected results.

Yes it's in the commit message and on the bug, tl:dr YESNO fields don't allow return NULL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@jswett77 jswett77 jswett77 left review comments

@Anthrino Anthrino Anthrino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tanclary @Anthrino @jswett77