Skip to content

Conversation

@u-m-i
Copy link

@u-m-i u-m-i commented Oct 22, 2025

Hi there! I stumble across your package in NPM, it looked great so I wanted to propose some changes; quoting from the commit:

The title for the section of the Ping class was updated to 'Abstract
Class', with the intention of noting that the class is not usable unless
extended.
All the links to the section were updated and some code blocks where
labeled with the language (cmd bash, text).
A simple addition was added to the clause "Ping is an EventEmitter"

PS: Please use a squeeze if you admit the PR, I tried to amend the commit but I did it wrong, resulting a duplicate commit but with the correction in the commit message.

u-m-i added 3 commits October 22, 2025 16:00
The title for the section of the `Ping` class was updated to 'Abstract
Class`, with the intention of noting that the class is not usable unless
extended.
All the links to the section were updated and some code blocks where
labeled with the language (`cmd bash`, `text`).
A simple addition was added to the clause "Ping is *an* EventEmitter"
The title for the section of the `Ping` class was updated to 'Abstract
Class', with the intention of noting that the class is not usable unless
extended.
All the links to the section were updated and some code blocks where
labeled with the language (`cmd bash`, `text`).
A simple addition was added to the clause "Ping is *an* EventEmitter"
@u-m-i u-m-i changed the title Chore/readme Remark the abstract of the Ping class signature Oct 22, 2025
@u-m-i u-m-i changed the title Remark the abstract of the Ping class signature Remark the abstract property of Ping Oct 22, 2025
@u-m-i
Copy link
Author

u-m-i commented Oct 22, 2025

This is my source for modifying the code blocks

<details><summary>Result (Console Output)</summary>

```
```text
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added as suggested here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant