default map needed for reverse proxy of websocket connections#67
Open
KoenDierckx wants to merge 1 commit intowodby:masterfrom
Open
default map needed for reverse proxy of websocket connections#67KoenDierckx wants to merge 1 commit intowodby:masterfrom
KoenDierckx wants to merge 1 commit intowodby:masterfrom
Conversation
Member
|
this nginx image isn't designed to be used as a reverse proxy, we expect people to use something like traefik for local environments and ingress-nginx in productiono |
Contributor
Author
|
We do use traefik to proxy dependent on the Host to the correct docker stack |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When doing a reverse proxy for a site with websockets, some additional 'http' configuration is needed
By providing this default generic map, the configuration can stay limited to the 'server' block but still use this 'http' variable.
Literal copy from the official documentation
http://nginx.org/en/docs/http/websocket.html
It should not have any impact on performance
http://nginx.org/en/docs/http/ngx_http_map_module.html
Since variables are evaluated only when they are used, the mere declaration even of a large number of “map” variables does not add any extra costs to request processing.