Hide score adjustments from leaderboard UI unless penalized#413
Hide score adjustments from leaderboard UI unless penalized#413zacjones93 wants to merge 1 commit intomainfrom
Conversation
The public leaderboard previously rendered a warning icon for any score with either a minor/major penalty or a plain organizer adjustment. Plain adjustments typically correct data-entry issues and a warning icon next to those scores reads as if something is wrong, which can confuse athletes. The penalty indicator (desktop and online/mobile variants), the row-level warning icon, and the expanded-view "Score adjusted by organizer" notices now gate on penaltyType alone. hasExpandableContent and the expanded-row filter likewise stop expanding rows solely because of a plain adjustment.
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 18 minutes and 36 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
2 participants
Summary
Refactors the leaderboard penalty indicator logic to only display warnings for scores with Minor or Major penalties. Plain score adjustments (marked
isDirectlyModifiedwithout apenaltyType) are now treated as routine data-entry corrections and no longer show warning badges or expanded notices to athletes.Key Changes
!result.penaltyType && !result.isDirectlyModifiedto!result.penaltyTypealone, removing the "Score Adjusted" label and popover detailr.isDirectlyModifiedfrom all conditions that determine which results show expandable content, so only penalty-bearing scores trigger the expanded viewImplementation Details
competition-leaderboard-table.tsxandonline-competition-leaderboard-table.tsxwere updated consistentlyaria-labelattribute was added to the online table's PenaltyIndicator for accessibilityr.videoUrl || r.penaltyType(removing the thirdr.isDirectlyModifiedclause)https://claude.ai/code/session_017n7WQe67Crk3vgyLMQck9j
Summary by cubic
Hide score adjustment warnings unless a Minor or Major penalty is present. Plain organizer adjustments no longer show badges, popovers, or expanded notices.
PenaltyIndicatornow renders only whenpenaltyTypeis set; removes the "Score Adjusted" label and popover.videoUrlorpenaltyType(removedisDirectlyModifiedfrom conditions).aria-labelto the online table indicator and updated copy to "A penalty was applied to this score."domain.mdto reflect the new behavior.Written for commit d7d42ec. Summary will update on new commits.