Skip to content

Add support for localized years #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions src/DateInput.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {
getEnd,
} from './shared/dates';
import { isMaxDate, isMinDate } from './shared/propTypes';
import { between } from './shared/utils';
import { between, getYearOffset } from './shared/utils';

const defaultMinDate = new Date();
defaultMinDate.setFullYear(1, 0, 1);
Expand Down Expand Up @@ -377,9 +377,17 @@ export default class DateInput extends PureComponent {
*/
onChange = (event) => {
const { name, value } = event.target;
const { locale } = this.props;

this.setState(
{ [name]: value },
() => {
if (name === 'year') {
const offset = getYearOffset(locale);
return { [name]: value !== null && value !== '' ? `${value - offset}` : null };
}

return { [name]: value };
},
this.onChangeExternal,
);
}
Expand Down Expand Up @@ -434,7 +442,8 @@ export default class DateInput extends PureComponent {

const values = {};
formElements.forEach((formElement) => {
values[formElement.name] = formElement.value;
const { [formElement.name]: value } = this.state;
values[formElement.name] = value;
});

if (formElements.every((formElement) => !formElement.value)) {
Expand Down Expand Up @@ -534,7 +543,9 @@ export default class DateInput extends PureComponent {
}

renderYear = (currentMatch, index) => {
const { autoFocus, yearAriaLabel, yearPlaceholder } = this.props;
const {
autoFocus, locale, yearAriaLabel, yearPlaceholder,
} = this.props;
const { year } = this.state;

return (
Expand All @@ -544,6 +555,7 @@ export default class DateInput extends PureComponent {
ariaLabel={yearAriaLabel}
autoFocus={index === 0 && autoFocus}
inputRef={this.yearInput}
locale={locale}
placeholder={yearPlaceholder}
value={year}
valueType={this.valueType}
Expand Down
16 changes: 13 additions & 3 deletions src/DateInput/YearInput.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,26 @@ import {
isRef,
isValueType,
} from '../shared/propTypes';
import { safeMax, safeMin } from '../shared/utils';
import { getYearOffset, safeMax, safeMin } from '../shared/utils';

export default function YearInput({
locale,
maxDate,
minDate,
placeholder = '----',
value,
valueType,
...otherProps
}) {
const maxYear = safeMin(275760, maxDate && getYear(maxDate));
const minYear = safeMax(1, minDate && getYear(minDate));

const offset = getYearOffset(locale);

const localizedMaxYear = maxYear + offset;
const localizedMinYear = minYear + offset;
const localizedValue = value !== null && value !== '' ? `${Number(value) + offset}` : null;

const yearStep = (() => {
if (valueType === 'century') {
return 10;
Expand All @@ -32,11 +40,12 @@ export default function YearInput({

return (
<Input
max={maxYear}
min={minYear}
max={localizedMaxYear}
min={localizedMinYear}
name="year"
placeholder={placeholder}
step={yearStep}
value={localizedValue}
{...otherProps}
/>
);
Expand All @@ -47,6 +56,7 @@ YearInput.propTypes = {
className: PropTypes.string.isRequired,
disabled: PropTypes.bool,
inputRef: isRef,
locale: PropTypes.string,
maxDate: isMaxDate,
minDate: isMinDate,
onChange: PropTypes.func,
Expand Down
9 changes: 9 additions & 0 deletions src/shared/utils.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { getFormatter } from './dateFormatter';

/**
* Returns a value no smaller than min and no larger than max.
*
Expand All @@ -15,6 +17,13 @@ export function between(value, min, max) {
return value;
}

export function getYearOffset(locale) {
const now = new Date();
return Number(
getFormatter({ year: 'numeric' })(locale, now).match(/\d{1,}/)[0],
) - now.getFullYear();
}

function isValidNumber(num) {
return num !== null && num !== false && !Number.isNaN(Number(num));
}
Expand Down