Skip to content

refactor sender types definition#108

Merged
wokron merged 7 commits intomasterfrom
simplify-sender-define
May 2, 2026
Merged

refactor sender types definition#108
wokron merged 7 commits intomasterfrom
simplify-sender-define

Conversation

@wokron
Copy link
Copy Markdown
Owner

@wokron wokron commented May 1, 2026

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the public sender type definitions to reduce duplication by introducing shared base templates, and adjusts ranged when_any precondition handling.

Changes:

  • Introduced OpSenderBase, ParallelSenderBase, and RangedParallelSenderBase and converted multiple sender classes to type aliases over these bases.
  • Added an empty-range runtime check for when_any(Range&&) (ranged overload) in sender_operations.hpp.
  • Renamed ranged operation state aliases in op_states.hpp for consistency (When*RangeOperationStateRangedWhen*OperationState).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
include/condy/senders.hpp Refactors sender type definitions into shared base templates; converts several sender types to aliases.
include/condy/sender_operations.hpp Adds empty-range validation for ranged when_any.
include/condy/op_states.hpp Renames ranged operation state aliases and updates inheritance accordingly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread include/condy/sender_operations.hpp
Comment thread include/condy/senders.hpp
@wokron wokron force-pushed the simplify-sender-define branch from a85a2e9 to 469d0cb Compare May 1, 2026 12:39
@wokron wokron marked this pull request as ready for review May 1, 2026 12:55
@wokron wokron merged commit de9f17d into master May 2, 2026
13 checks passed
@wokron wokron deleted the simplify-sender-define branch May 2, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants