Conversation
There was a problem hiding this comment.
Pull request overview
Refactors the public sender type definitions to reduce duplication by introducing shared base templates, and adjusts ranged when_any precondition handling.
Changes:
- Introduced
OpSenderBase,ParallelSenderBase, andRangedParallelSenderBaseand converted multiple sender classes to type aliases over these bases. - Added an empty-range runtime check for
when_any(Range&&)(ranged overload) insender_operations.hpp. - Renamed ranged operation state aliases in
op_states.hppfor consistency (When*RangeOperationState→RangedWhen*OperationState).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| include/condy/senders.hpp | Refactors sender type definitions into shared base templates; converts several sender types to aliases. |
| include/condy/sender_operations.hpp | Adds empty-range validation for ranged when_any. |
| include/condy/op_states.hpp | Renames ranged operation state aliases and updates inheritance accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a85a2e9 to
469d0cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.